Draft
Conversation
|
This reverts commit 79e60c4.
72636c
changed the title
72636c
commented
Apr 2, 2024
Comment on lines
+49
to
+56
| await runBuild({ | ||
| bundle: true, | ||
| compilerOptions: { | ||
| ...compilerOptions, | ||
| module: ModuleKind.ESNext, | ||
| }, | ||
| debug, | ||
| entryPoints, |
Member
Author
There was a problem hiding this comment.
I think these entryPoints are not correct for bundle: true. Strictly speaking it should only output the root lib/index.mjs unless more exports are defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshots via
cjs-mjs-outputtag: https://www.npmjs.com/package/skuba?activeTab=versionsnpm i skuba@cjs-mjs-outputThis is an experimental feature that currently requires:
package.json{ "files": [ "lib*/**/*.d.ts", "lib*/**/*.js", "lib*/**/*.js.map", + "lib*/**/*.mjs", + "lib*/**/*.mjs.map" ], - "main": "./lib-commonjs/index.js", + "main": "./lib/index.js", - "module": "./lib-es2015/index.js", + "module": "./lib/index.mjs", - "types": "./lib-types/index.d.ts", + "types": "./lib/index.d.ts", "scripts": { "build": "skuba build-package" }, "skuba": { + "build": "esbuild", "version": "x.x.x" }, }To do:
declarationandremoveCommentsin this mode, in pursuit of zero configbuild-packageas a separate command? It may be better to consolidate onbuildwith support for configuration; we can setpackage.json#/skuba/buildtoesbuildtoday, and we could add an option for e.g.hybridoutput.lib-commonjsandlib-es2015output? How safe will it be to switch to esbuild and modern targets?skuba lintautofixes or askuba migratefor ^?